[core] Fix nested update agg dropping existing-key updates at count limit#8272
Open
QuakeWang wants to merge 1 commit into
Open
[core] Fix nested update agg dropping existing-key updates at count limit#8272QuakeWang wants to merge 1 commit into
QuakeWang wants to merge 1 commit into
Conversation
…imit When a nested-key was configured together with a count limit, `agg` returned the accumulator unchanged as soon as `acc.size() >= countLimit`. This early return was shared with the no-key path, so once the nested array reached the limit, updates to already-existing keys (and sequence-based updates) were silently dropped instead of being applied. Split the two paths: the no-key path keeps the count-limit truncation behavior, while the keyed path merges rows by key into a map. Existing keys are always updated (honoring the nested-sequence-field when set) and the count limit only caps the number of new keys, so in-place updates are no longer lost at the limit. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a nested-key was configured together with a count limit,
aggshort-circuited withif (acc.size() >= countLimit) return accumulator;. This early return was shared with the no-key path, so once the nested array reached the limit, updates to existing keys (andnested-sequence-fieldupdates) were silently dropped — the limit was meant to bound the number of distinct keys, not block in-place updates.This PR splits the two paths: the no-key path keeps the count-limit truncation, while the keyed path merges by key so existing keys are always updated and the limit only caps the number of new keys.
Tests
mvn test -pl paimon-core -Dtest=FieldAggregatorTest